Skip to content

Simplify makeSchema by returning the results #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 26, 2021

No need to return a function and then execute it when you can return the result.

cc: @plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jun 26, 2021
@archmoj archmoj merged commit e43867f into master Jun 26, 2021
@archmoj archmoj deleted the simplify-make-schema branch June 26, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant