Skip to content

Devtools patch #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2016
Merged

Devtools patch #416

merged 2 commits into from
Apr 11, 2016

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented Apr 11, 2016

Fixes #404 and improves perceived search performance.

  • Set interval check to run onReload function only after the new plotly.js bundle has loaded.
  • Debounce the fuzzy search for mocks by 250ms.

@etpinard
Copy link
Contributor

@mdtusz Pardon my ignorance: why do we need to debounce the fuzzy search?

@mdtusz
Copy link
Contributor Author

mdtusz commented Apr 11, 2016

The search was being run on every keyup before - on my machine that blocks things and is surprisingly slow. We could also just run the search when there's an enter keypress if you'd prefer.

@etpinard
Copy link
Contributor

@mdtusz thanks. 💃

This looks good. I don't see the need to implement an <enter> handle.

@mdtusz mdtusz merged commit db9fd34 into master Apr 11, 2016
@mdtusz mdtusz deleted the devtools-patch branch April 11, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants