Skip to content

Bug fix 3D grid lines and tick labels colored by rgba color with full transparency #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Bug fix 3D grid lines and tick labels colored by rgba color with full transparency #3494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3fe4ab
fix3439-opacity
archmoj Jan 29, 2019
8608dd3
added a mock to lock the bug
archmoj Jan 29, 2019
403bfda
added baseline to lock bug reported in issue 3493
archmoj Jan 29, 2019
209edd8
bumping gl-vis modules
archmoj Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@
"font-atlas-sdf": "^1.3.3",
"gl-cone3d": "^1.2.2",
"gl-contour2d": "^1.1.5",
"gl-error3d": "^1.0.11",
"gl-error3d": "^1.0.12",
"gl-heatmap2d": "^1.0.5",
"gl-line3d": "^1.1.8",
"gl-line3d": "^1.1.9",
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.7",
"gl-plot2d": "^1.4.2",
"gl-plot3d": "^1.6.3",
"gl-pointcloud2d": "^1.0.2",
"gl-scatter3d": "^1.1.4",
"gl-scatter3d": "^1.1.5",
"gl-select-box": "^1.0.3",
"gl-spikes2d": "^1.0.2",
"gl-streamtube3d": "^1.1.2",
Expand Down
Binary file added test/image/baselines/gl3d_scatter3d_line3d_error3d_transparent-with-zero-alpha.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 46 additions & 0 deletions test/image/mocks/gl3d_scatter3d_line3d_error3d_transparent-with-zero-alpha.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"data": [
{
"x": [0, 1, 2, 3, 4],
"y": [0, 1, 2, 3, 4],
"z": [0,-1,-2,-3,-4],
"mode": "markers+lines",
"marker": {
"size": 50,
"color": ["rgb(0, 255, 0, 0.5)", "rgb(255, 0, 0, 0.0)", "rgb(255, 0, 0, 0.0)", "rgb(255, 0, 0, 0.0)", "rgb(0, 0, 255, 1.0)"],
"opacity": 0.999
},
"line": {
"width": 50,
"color": ["rgb(0, 255, 0, 0.5)", "rgb(255, 0, 0, 0.0)", "rgb(255, 0, 0, 0.0)", "rgb(255, 0, 0, 0.0)", "rgb(0, 0, 255, 1.0)"],
"opacity": 0.999
},
"error_z": {
"type": "sqrt",
"line": { "thickness": 10 },
"color": "rgb(0, 255, 0, 0.0)",
"opacity": 0.999
},
"error_x": {
"type": "sqrt"
},
"error_y": {
"type": "sqrt"
},
"type": "scatter3d"
}
],
"layout": {
"title": {
"text": "Should not draw transparent scatter3d markers and lines<br>when color.alpha is zero"
},
"width": 600,
"height": 600,
"scene": {
"xaxis": { "nticks": 12 },
"yaxis": { "nticks": 12 },
"zaxis": { "nticks": 12 }
}
}

}