Problem adding/removing mapbox layers via Plotly.react

[etpinard]

From https://codepen.io/nicolaskruchten/pen/pOVLop

Couple ways to hit the problem:

• step 0 -> step 1 -> step 2 -> step 3 fails
• step 0 -> step 1 -> step 0 fails

[etpinard]

@nicolaskruchten

Looks like Plotly.react doesn't clear the rejected promises before plotting.

Adding

        var gd = document.getElementById('gd')
        gd._promises = [];

before the Plotly.react call to the above codepen (see https://codepen.io/etpinard/pen/oNvPRGX?editors=1010) appears to fix the "figure getting wedged" problem. Note that the console errors are still there.

This is a general Plotly.react bug. restyle, relayout and update all call

plotly.js/src/plot_api/helpers.js

Lines 24 to 31 in 832590b

	// clear the promise queue if one of them got rejected
	exports.clearPromiseQueue = function(gd) {
	if(Array.isArray(gd._promises) && gd._promises.length > 0) {
	Lib.log('Clearing previous rejected promises from queue.');
	}
	gd._promises = [];
	};

before attempting a redraw.

---

Now we could also do a better job at identifying bad mapbox layout layer inputs like

Plotly.newPlot(gd, [{type: 'scattermapbox'}], {
  mapbox: {
    layers: [{
      sourcetype: 'raster',
      source: ['']
    }]
  }
})

which will of course fail at fetch time.

---

Moreover,

Plotly.newPlot(gd, [{type: 'scattermapbox'}], {
  mapbox: {
    layers: [{}]
  }
})
.then(gd => {
  Plotly.react(gd, [{type: 'scattermapbox'}], {
    mapbox: {
      layers: []
    }
  })
})

should not fail.

[nicolaskruchten]

Ah ok, that's helpful, thanks very much!

[etpinard]

-> https://codepen.io/etpinard/pen/qBWMzoj is now error and "wedge" free.