matches with animations

[nicolaskruchten]

The following pen is super long, sorry, but it shows animations with matched X axes where x1 has a fixed range. The matching appears broken :(

https://codepen.io/nicolaskruchten/pen/gqJoOJ?editors=0010

[etpinard]

Is this a requirement for 1.45.0?

[nicolaskruchten]

We can push it out of scope for 1.45.0 but without it, px will have to be released without animations, so fixing it will be at the top of the 1.45.1 pile :)

[etpinard]

I wouldn't call that a bug fix, so all right let's make this part of 1.45.0.

[etpinard]

The "animation" in https://codepen.io/nicolaskruchten/pen/gqJoOJ?editors=0010 seems to work ok when using the correct bundle and setting all the x-axis to type: 'log':

• https://codepen.io/etpinard/pen/KJLJJr

and things work ok when unsetting xaxis.type as well:

• https://codepen.io/etpinard/pen/Gzazzv

Even "axes" transitions on matching axes seem to work ok:

• https://codepen.io/etpinard/pen/vbwPBZ?editors=1010

---

Now, maybe having

layout = {
  xaxis: {type: 'log'},
  xaxis2: {matches: 'x'}
}

should infer that xaxis2.type is 'log'? I'd vote no, but I could be convinced otherwise.

[nicolaskruchten]

Ahhh interesting. Would you be surprised if I voted the other way from you? I could be convinced otherwise also though :)

[etpinard]

My main argument is: "that how is works right now for scaleanchor", where trying to constraint axes of different types (you can add config option logging: 2 to see those warnings in the console) results in this message:

plotly.js/src/plots/cartesian/constraints.js

Lines 87 to 91 in b5663aa

	Lib.warn('ignored ' + containerOut._name + '.scaleanchor: "' +
	containerIn.scaleanchor + '" to avoid either an infinite loop ' +
	'and possibly inconsistent scaleratios, or because the target ' +
	'axis has fixed range or this axis declares a *matches* constraint.');
	}

[etpinard]

@nicolaskruchten Anything here still blocking for 1.45.0? Can we close this ticket?

[nicolaskruchten]

Can close

…

On Mon, Feb 25, 2019 at 09:29 Étienne Tétreault-Pinard < ***@***.***> wrote: @nicolaskruchten <https://github.com/nicolaskruchten> Anything here still blocking for 1.45.0? Can we close this ticket? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3562 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMbA9vJqhH97XpRtJLC8k-sPE91dkYXks5vQ_NJgaJpZM4bHqsY> .