no variable shadowing

[alexcjohnson]

consider enabling https://eslint.org/docs/rules/no-shadow - can save us from some very confusing bugs.

As @etpinard mentions in #3017:

That would require some work though, as no-shadow fails in more than 500 times in our codebase.

[etpinard]

Now in -> #3162 (comment)