add .embed to iframe #243
Merged
add .embed to iframe #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
cool, thanks! |
Collaborator
On TravisCI, commit 095c814 was successfully merged with 4b4f774 (master) to create 085e8f3. A visual testing table comparing 4b4f774 with 085e8f3 can be found here -> http://cpsievert.github.io/plotly-test-table/R/085e8f3/ Detected 0 differences |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise plotly will detect that the graph is in an iframe, and redirect to
.embedanyway. so, this should make plotly embeds load ~2 seconds faster :)cc @cpsievert