Improve logging #29
Improve logging #29
Conversation
| head: info.head, | ||
| processingTime: info.processingTime | ||
| } | ||
| })) |
There was a problem hiding this comment.
There was a problem hiding this comment.
perhaps we could use a severity field in the after-export section. maybe 'INFO'?
There was a problem hiding this comment.
That looks good to me. Have you been able to deploy it to stage and see if it looks OK on Stackdriver?
There was a problem hiding this comment.
Hmm. I just tried doing that via plotbot, but I got:
There was a problem hiding this comment.
I think I've fixed Plotbot permissions, but there's no Docker image to deploy.
The Docker build needs to succeed before you can deploy.
There was a problem hiding this comment.
(This may have been an intermittent CircleCI issue so I'm going to retry the build.)
There was a problem hiding this comment.
The rebuild worked. Now I'm dealing with a different deployment issue.
There was a problem hiding this comment.
OK, that worked. The latest version of this branch has been deployed to stage.
There was a problem hiding this comment.
There was a problem hiding this comment.
perhaps we could use a severity field in the after-export section. maybe 'INFO'?
done in cbb4e13
|
cc @bpostlethwaite who might be interested in helping out. |
| } | ||
| }) | ||
|
|
||
| app.on('export-error', (info) => { | ||
| if (SHOW_LOGS) { | ||
| console.log(`export error ${info.code} - ${info.msg}`) | ||
| console.log(JSON.stringify({ | ||
| severity: 'ERROR', |
| console.warn(err) | ||
| if (SHOW_LOGS) { | ||
| console.log(JSON.stringify({ | ||
| severity: 'ERROR', |
|
@scjody @bpostlethwaite wanna give this another 👁️ ? |
resolves #2