This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Update component gen process for recent MDN changes #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrgss
approved these changes
Jan 7, 2021
| const excludeElements = [ | ||
| 'html', 'head', 'body', 'style', 'h1–h6', 'input', | ||
| // out of scope, different namespaces - but Mozilla added these to the | ||
| // above reference page Jan 2021 so we need to exclude them now. |
There was a problem hiding this comment.
perhaps reference the MDN PR that changed this for posterity? mdn/content#410
There was a problem hiding this comment.
Ah nice, I didn't think to look for where this was introduced!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an extra error message if the number of elements we extract is different from what was expected. This should fix the build errors in for example plotly/dash#1508