-
-
Notifications
You must be signed in to change notification settings - Fork 42
Closed
Labels
priorityDash.jl tasks that should be completed prior to non-priority itemsDash.jl tasks that should be completed prior to non-priority items
Description
Following discussion offline with @alexcjohnson, we should rename the id
argument of callback!
to params
, which aligns with current Dash convention. We already use id
as a property within Dash components, so this usage is potentially confusing as-is.
This is a breaking change in the Dash.jl API, and we should probably make the modification sooner rather than later.
Line 52 in b50e5dc
function callback!(func::Function, app::DashApp, id::CallbackId) |
This likely implies that we should consider renaming CallbackId
to Params
(or SetParams
or Setparms
or setparms
) and callid_str
to params_str
(and, callid
also):
Dash.jl/src/app/supporttypes.jl
Line 3 in b50e5dc
struct CallbackId |
Line 78 in b50e5dc
macro callid_str(s) |
Metadata
Metadata
Assignees
Labels
priorityDash.jl tasks that should be completed prior to non-priority itemsDash.jl tasks that should be completed prior to non-priority items