-
Notifications
You must be signed in to change notification settings - Fork 32
Upgrade golang.org/x/crypto and other deps #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @djshow832 |
|
@dveeden: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage ? 65.65%
=======================================
Files ? 138
Lines ? 14060
Branches ? 0
=======================================
Hits ? 9231
Misses ? 4182
Partials ? 647
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI reports Maybe I need to ask the EE team to upgrade Go. |
Yes going from 1.23 to 1.24 or even better 1.25 would be good. The best before date for 1.23 is getting closer. |
|
I told him to upgrade the builder version but it may take some time. Please upgrade directly to v1.25 if you have time. |
What problem does this PR solve?
Problem Summary:
Note that we do not use the vulnerable part of x/crypto, but would still be good to upgrade to a safer version.
What is changed and how it works:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.