Skip to content

Update follower read and learner read descriptions #20609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2025
Merged

Update follower read and learner read descriptions #20609

merged 7 commits into from
Sep 19, 2025

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Jul 3, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

The description of follower-read and learner-read is inaccurate, and related behaviors have been adjusted in the newer version of tidb, so the corresponding documentation has been revised accordingly.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025
@zyguan
try to fix ci
984ac18 
Signed-off-by: zyguan <[email protected]>
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Jul 15, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 15, 2025
@lilin90 lilin90 self-assigned this Jul 15, 2025
@lilin90 lilin90 added the type/outdated Indicates that the content is outdated. label Jul 15, 2025
@lilin90 lilin90 changed the title revise the doc of follower read Update follower read and learner read descriptions Jul 15, 2025
@lilin90 lilin90 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jul 15, 2025
@lilin90 lilin90 assigned hfxsd and unassigned lilin90 Jul 17, 2025
hfxsd
hfxsd reviewed Jul 24, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jul 24, 2025
View reviewed changes
zyguan and others added 2 commits July 24, 2025 12:36
@zyguan @hfxsd
Update follower-read.md
8251896 
Co-authored-by: xixirangrang <[email protected]>
@zyguan @hfxsd
Update follower-read.md
b2edc3a 
Co-authored-by: xixirangrang <[email protected]>
@zyguan zyguan mentioned this pull request Jul 29, 2025
Merged
14 tasks
@zyguan zyguan requested review from cfzjywxk and you06 August 5, 2025 08:52
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 15, 2025
hfxsd
hfxsd reviewed Sep 15, 2025
View reviewed changes
hfxsd
hfxsd reviewed Sep 15, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2025
@lilin90 lilin90 mentioned this pull request Sep 16, 2025
Open
14 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2025

@you06: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2025

@cfzjywxk: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hfxsd
hfxsd reviewed Sep 19, 2025
View reviewed changes
@hfxsd hfxsd requested a review from qiancai September 19, 2025 08:13
qiancai
qiancai approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-15 23:40:15.330800615 +0000 UTC m=+923081.890682102: ☑️ agreed by hfxsd.
  • 2025-09-19 08:36:30.861364642 +0000 UTC m=+200.931858323: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator

hfxsd commented Sep 19, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 19, 2025
This was referenced Sep 19, 2025
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit 0545aa4 into pingcap:master Sep 19, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20938.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 19, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20939.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 19, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20940.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 19, 2025
Merged
16 tasks
@hfxsd
Copy link
Collaborator

hfxsd commented Sep 22, 2025

/approve

ti-chi-bot bot pushed a commit that referenced this pull request Sep 22, 2025
@ti-chi-bot
Update follower read and learner read descriptions (#20609) (#20938)
a8b41f3
ti-chi-bot bot pushed a commit that referenced this pull request Sep 22, 2025
@ti-chi-bot
Update follower read and learner read descriptions (#20609) (#20940)
c7f5f41
ti-chi-bot bot pushed a commit that referenced this pull request Sep 22, 2025
@ti-chi-bot
Update follower read and learner read descriptions (#20609) (#20939)
910b0dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@you06 you06 you06 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/outdated Indicates that the content is outdated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zyguan @cfzjywxk @hfxsd @ti-chi-bot @you06 @qiancai @lilin90