[Fix] Add missing dateutil dep #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haruska
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SDK version 5.3.0 was accidentally shipped with a missing dependency. This wasn't caught in testing because the dependency was present in our
poetry.lock, which is used when installing in CI, but not inpyproject.tomlso it wasn't included for the published package. We got into this state because we used to have a dependency onpython-dateutilwhich was removed and later re-added when date parsing was needed for support of import endpoints (added 5.3.0).Additional manual testing in google colab didn't catch this either because that environment loads
python-dateutilas part of the default environment. 🤦♀️Solution
Add missing dependency.
Type of Change