Skip to content

Conversation

@gdj0nes
Copy link
Contributor

@gdj0nes gdj0nes commented Jun 14, 2024

Problem

PRs often include formatting changes that makes it difficult to identify changes in functionality

Solution

  • Format all code with black
  • Introduce linting black linting workflow

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

@gdj0nes gdj0nes requested a review from jhamon June 14, 2024 13:36
@gdj0nes
Copy link
Contributor Author

gdj0nes commented Jun 14, 2024

Confirmed pre-commit runs after refreshing the venv

@gdj0nes gdj0nes merged commit 320afc1 into main Jun 20, 2024
@gdj0nes gdj0nes deleted the black-fmt branch June 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants