Skip to content

Allow colon inside source tags #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Allow colon inside source tags #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5630b60
Allow colon on source tags
jhamon Jun 4, 2024
9118397
No need to escape colon
jhamon Jun 4, 2024
b9b19ae
Update comment
jhamon Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pinecone/utils/user_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
def _build_source_tag_field(source_tag):
# normalize source tag
# 1. Lowercase
# 2. Limit charset to [a-z0-9_ ]
# 2. Limit charset to [a-z0-9_ :]
# 3. Trim left/right whitespace
# 4. Condense multiple spaces to one, and replace with underscore
tag = source_tag.lower()
tag = re.sub(r'[^a-z0-9_ ]', '', tag)
tag = re.sub(r'[^a-z0-9_ :]', '', tag)
tag = tag.strip()
tag = "_".join(tag.split())
return f"{SOURCE_TAG}={tag}"
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/utils/test_user_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ def test_source_tag_is_normalized(self):
useragent = get_user_agent(config)
assert re.search(r"source_tag=my_source_tag_123", useragent) is not None

config = ConfigBuilder.build(api_key="my-api-key", host="https://my-controller-host", source_tag="colon:allowed")
useragent = get_user_agent(config)
assert re.search(r"source_tag=colon:allowed", useragent) is not None

def test_user_agent_grpc(self):
config = ConfigBuilder.build(api_key="my-api-key", host="https://my-controller-host")
useragent = get_user_agent_grpc(config)
Expand Down