adds util for checking kwargs, and uses it to check init() #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per #196 a typo in init's kwargs results in a default that might not be expected.
Solution
Utils now includes check_kwargs, which takes a caller + the given kwargs, and fails with a traceback if they don't match.
Open Questions
cc @jhamon @austin-denoble @rohanshah18
init
in particular i question its value.Type of Change
Test Plan
pinecone.init(not_a_kwarg='foo')
should fail