Replace deprecated HTTPResponse.getheader() #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamon
approved these changes
Aug 21, 2023
7 tasks
tdonia
added a commit
that referenced
this pull request
Aug 24, 2023
## Problem Follow up to #195, which updated to use `urllib.headers` -- there's also a deprecation for `getheader` coming: urllib3/urllib3#2814 ## Solution Updated the call in `rest.py` to use `.get` instead of `.getheader`; based on the [code](https://github.com/urllib3/urllib3/blob/1.2.1/urllib3/response.py#L191C29-L191C32) this should be compatible with 1.2.1, [our current min version](https://github.com/pinecone-io/pinecone-python-client/blob/main/requirements.txt#L8) ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan REST requests should work without a notice in URLLib3 2.0.4+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See gh-125
Solution
This PR simply replaces the deprecated
HTTPResponse.getheader()usages with the suggestedHTTResponse.headers.Type of Change
Test Plan
Describe specific steps for validating this change.