Add BME688 module with a framework for adding new QW/ST modules #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the BME688 so I can get offboard temperature readings to compare with the onboard BME280 on the weather board seemingly affected by heat dissipated from running constantly.
Module code is defined in a new enviro subfolder and called with some modification to __init__.py with users able to enable the module, including those with non-default addresses by adjusting the entry in config.py.
Documentation updated to show the new module as a tutorial for adding others. This extends the changes in #184
After spending half a day building this, I've just seen #143 which has a fairly similar approach for a different new module. I'm leaving this PR for discussion purposes as the solutions differ here and there.