Skip to content

Add support for @phpstan-throws #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

VincentLanglet
Copy link
Contributor

I messed up with the PR #291

@ondrejmirtes
Copy link
Member

I see the problem. It's not your fault.

@ondrejmirtes
Copy link
Member

Please rebase on top of master, the build should pass. Thanks.

@VincentLanglet
Copy link
Contributor Author

Sure, rebase done !

@ondrejmirtes
Copy link
Member

The tests related to this PR are failing.

@VincentLanglet
Copy link
Contributor Author

@ondrejmirtes I made some fixes. Can I do something for the Build/Phpstan failures ?

@ondrejmirtes
Copy link
Member

@VincentLanglet Thank you, I'm working on a fix right now :)

@ondrejmirtes ondrejmirtes merged commit 7c4f331 into phpstan:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants