Skip to content

Add assertSame test case with static method #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 10, 2022

This is basically a regression test and closes #120

@herndlm
Copy link
Contributor Author

herndlm commented Mar 10, 2022

Would be nice to have one for assertNotSame, which is actually used in that bug, too. mom

@ondrejmirtes ondrejmirtes merged commit 886dab7 into phpstan:master Mar 10, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the add-assert-same-test-case-with-static-method branch March 10, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in PHPStan 1.4.8 with assertNotSame with instances of the same class
2 participants