fix trends not displayed correctly #531
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpMetrics v2.9.1
Description:
Fixing trends not being displayed correctly.
Current behavior:
The trends in the html report will always show the current value and a trend of minus that value.
Correct behavior:
show actual trend change
Root cause:
Hal\Report\Html\Reporter.php:255
checks forisset($this->sum->$type->$key)
which will never be set, resulting in$newValue
being assigned 0, causing the trend to be0 - $oldValue
.Fix:
Changing the lookup to
$this->$type->$key
from$this->sum->$type->$key
checks for the correct variable.