Skip to content

implement parsing of CAST(), automatically parse dates inside literals #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2014
Merged

implement parsing of CAST(), automatically parse dates inside literals #99

merged 1 commit into from
Jan 7, 2014

Conversation

lsmith77
Copy link
Member

@lsmith77 lsmith77 commented Jan 7, 2014

fix #98

@lsmith77 lsmith77 mentioned this pull request Jan 7, 2014
Merged
dbu
dbu reviewed Jan 7, 2014
View reviewed changes
src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php
@@ -2,6 +2,8 @@

namespace PHPCR\Util\QOM;

use Jackalope\Property;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this was left by accident? phpcr-utils does not depend on Jackalope.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lsmith77
Copy link
Member Author

lsmith77 commented Jan 7, 2014

did a minor refactoring .. but its not so simple with the code duplication. i ran into issues with the call to $this->scanner->getPreviousDelimiter() with a date that contained a dot character (i.e. '.') .. not sure if this is a general issue with this code to try and fix delimiters that are "eaten" by the parser but the gist is that right now the code is not the same ..

dbu added a commit that referenced this pull request Jan 7, 2014
@dbu
Merge pull request #99 from phpcr/parse_cast
75795a8 
implement parsing of CAST(), automatically parse dates inside literals
@dbu dbu merged commit 75795a8 into master Jan 7, 2014
@dbu dbu deleted the parse_cast branch January 7, 2014 20:05
@dbu
Copy link
Member

dbu commented Jan 7, 2014

ah, that seems strange. we should be able to parse anything that is in a quoted string i guess. should we open an issue about that?

@dbu
Copy link
Member

dbu commented Jan 7, 2014

but thanks for implementing CAST and date guessing! cool that we have this now!

This was referenced Jan 7, 2014
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql2 parser does not support CAST
2 participants
@lsmith77 @dbu