Backport of #185 #186
Merged
Backport of #185 #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-import-uuid-behavior Added option to control the uuid-behavior
|
@dbu this should be the last one :) thanks for merging, tagging and just everything ;) |
dbu
reviewed
Feb 12, 2018
| @@ -94,6 +94,7 @@ public function testNodeUpdate($options) | |||
| $this->setupQueryManager($options); | |||
|
|
|||
| $args = [ | |||
| '--query-language' => 'jcr-sql2', | |||
There was a problem hiding this comment.
the original solution was to completely drop this argument: b222c2a . for the 1.2 branch i think it was simply never fixed, i think we can just leave it as is there. but can you please delete it here?
the thing is: sql2 is default, but if you specify a query language option, you have to specify a value for it.
There was a problem hiding this comment.
@dbu should be fixed
|
tagged 1.3.3 with this |
|
@dbu thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.