small cleanup

[pavelvondrasek]

No description provided.

[dbu]

i like all the changes.

regarding the installation failure with uuid: lets raise the branch alias to 1.3 in composer.json and increase minimum php version to 5.6 in .travis.yml and composer.json. can you add that in this pull request?

[pavelvondrasek]

Of course I can :)

[dbu]

thanks!

if you want to replace the getMock calls with createMock (and ::class pseudo-constants), that would now be possible as we have php 5.6

[pavelvondrasek]

Thank you too, David!

Yes I want :) I will do it!

Isn't bad that we haven't phpunit in dev-dependencies?

[dbu]

this is an often disputed question and one i myself have no real opinion on. on one hand, its not really a dependency of our code, only of the tests. on the other hand, we would reliably know which phpunit version is used and have the tests written for that version.

as its require-dev there is no impact on users of this library, so if you want to change it, feel free :-)

[pavelvondrasek]

Ok, I think that will be better to know for which version are tests written I think it's transparent :)

Which phpunit version you prefer in dev-deps?

[dbu]

Which phpunit version you prefer in dev-deps?

i don't mind. it needs to be one that works with php 5.6 and 7 so i guess phpunit 5.6 or 5.7 should work.

[pavelvondrasek]

Ok :-)