InvalidQueryException on Windows for correct query

[alexander-schranz]

In sulu currently the CI is failing because of a query is not working correctly: https://github.com/sulu/sulu/runs/4532843563?check_suite_focus=true

Interesting is that it only fails on the Windows machine with the following error:

PHPCR\Query\InvalidQueryException: Syntax error: Expected ')', found '' in SELECT *
                 FROM [nt:unstructured] as page
                 WHERE (page.[jcr:mixinTypes] = 'sulu:page'
                       OR page.[jcr:mixinTypes] = 'sulu:home')
                       AND isdescendantnode(page, '/cmf/sulu_io')

D:\a\sulu\sulu\vendor\phpcr\phpcr-utils\src\PHPCR\Util\QOM\Sql2Scanner.php:94
D:\a\sulu\sulu\vendor\phpcr\phpcr-utils\src\PHPCR\Util\QOM\Sql2ToQomQueryConverter.php:419
D:\a\sulu\sulu\vendor\phpcr\phpcr-utils\src\PHPCR\Util\QOM\Sql2ToQomQueryConverter.php:361
D:\a\sulu\sulu\vendor\phpcr\phpcr-utils\src\PHPCR\Util\QOM\Sql2ToQomQueryConverter.php:118

There seems also other issues where the query is false.

Machine runs on PHP 7.4.

The query itself looks coorect from my point of view.

@mamazu any idea what could cause this problem?

[alexander-schranz]

Seems like the problem is the multiline queries: #205. Sounds for me like an issue with \n, \r, \r\n.

[mamazu]

Appearently the strtok function did more than just split a string by a delimiter. For a quick fix can you try to add "\r" to the array in here:

phpcr-utils/src/PHPCR/Util/QOM/Sql2Scanner.php

Line 155 in 1563098

if (!$stringStartCharacter && in_array($character, [' ', "\t", "\n"], true)) {

This should solve the problem. If it does, I can create a merge request for it.

[alexander-schranz]

@mamazu Thx for the quick response. Seems to fix it: #205. Will try to run sulu against that branch.

[alexander-schranz]

Did also fix all query issues on the sulu side: https://github.com/sulu/sulu/runs/4533905041?check_suite_focus=true