-
Notifications
You must be signed in to change notification settings - Fork 21
Added queries testing nested joins #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@richard-fizz ok great .. now can you adjust your composer.json in jackalope/jackalope-doctrine-dbal#318 to use your branch in your repository (see also https://getcomposer.org/doc/05-repositories.md#using-private-repositories)? this way we can automatically verify that your code passes the tests. ideally you would then also create a similar PR for https://github.com/jackalope/jackalope-jackrabbit once we have confirmed that your tests pass with both we will merge this PR and create a new tag. you will then have to update your PRs again to use this new tag instead of your own branch. |
Pushed the modified composer.json to jackalope/jackalope-doctrine-dbal#318. |
can you please add one test that is actually run against the repository? the tests you add so far are good, they test the parser and converter. but we should have one in QuerySql2OperationsTest, along the lines of testQueryJoinWithAlias https://github.com/phpcr/phpcr-api-tests/blob/master/tests/Query/QuerySql2OperationsTest.php#L168 - maybe call it testQueryJoinNested ? (no need to test all the other join situations with nested, just one more that does a nested join) |
Done. Did find one more issue using the new test and solved it right away. Should work properly now. |
the tests work with jackalope-jackrabbit as well. can you please squash the commits into one? then i can merge this and tag a version that we can use in jackalope |
StyleCI fix Added testQueryJoinNested
Did I squash the commits properly...? Never done it before. |
no, not really ;-)
now i have a clean history. if i was the author, i would now as it is, i merged the PR on the command line and pushed as 772f2df |
Added tests to check whether nested joins are working. These work with my nested join implementations in jackalope/jackalope-doctrine-dbal and phpcr/phpcr-utils