adding tests for Node::getDefinition #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2015
dbu
force-pushed
the
node-get-definition
branch
from
d634fc0 to
80068d7
Compare
dbu
force-pushed
the
node-get-definition
branch
from
80068d7 to
7dcde3c
Compare
dbu
force-pushed
the
node-get-definition
branch
from
7dcde3c to
f9198eb
Compare
| * Node definition of a hierarchy node. | ||
| * | ||
| * @var NodeDefinitionInterface | ||
| */ | ||
| private $hierarchyNodeDef; | ||
|
|
||
| public static function setupBeforeClass($fixtures = false) |
There was a problem hiding this comment.
the problem in jackalope-doctrine-dbal was that we have no fixtures we load for this test. in jackrabbit, fixtures are not removed in this case so we did not see the mistake. separated the tests now.
|
this fixed jackalope/jackalope-doctrine-dbal#296, will merge. |
dbu
added a commit
that referenced
this pull request
Aug 15, 2015
adding tests for Node::getDefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used in jackalope/jackalope-jackrabbit#114