Added test for maintaining references after copying #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @wachterjohannes |
dantleech
force-pushed
the
copy_update_referrers
branch
from
5449471 to
5eab291
Compare
| $src = '/tests_write_manipulation_copy/testCopyUpdateReferrersSingleValue/srcNode'; | ||
| $dst = '/tests_write_manipulation_copy/testCopyUpdateReferrersSingleValue/dstNode'; | ||
| $ref = '/tests_write_manipulation_copy/testCopyUpdateReferrersSingleValue/referencedNode'; | ||
|
|
||
| $this->ws->copy($src, $dst); |
There was a problem hiding this comment.
we should have the assertions before and after refreshing, to make sure both the object state and the storage state are correctly updated.
|
@dantleech can you please update this test to assert both before and after refreshing to be sure both memory state and database get updated? |
|
Updated. |
dbu
added a commit
that referenced
this pull request
Apr 13, 2015
Added test for maintaining references after copying
|
thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to expose bug reported in jackalope/jackalope-doctrine-dbal#251