CI updates #52
Merged
CI updates #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'd like to leave the ECS cleanup for a follow-up PR, one that probably includes adding typehints and return types if needed. |
mvriel
reviewed
Jan 10, 2018
easy-coding-standard.neon
Outdated
| - PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer | ||
|
|
||
| skip: | ||
| # SlevomatCodingStandard\Sniffs\Classes\UnusedPrivateElementsSniff: |
Member
There was a problem hiding this comment.
Perhaps best to remove the commented code if it doesn't do anything? :)
jeremiemychezmoi
pushed a commit
to jeremiemychezmoi/TypeResolver
that referenced
this pull request
Jul 9, 2019
CI updates Former-commit-id: 4f2d9c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.