Improvements for #9 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounted as equal to ensure we end at the correct point
Contributor
Author
There was a problem hiding this comment.
Not sure which PHP version you'd like coverage of, so I used 5.6 which is as good as any ^_^
Member
|
Thanks James, my apologies that it took so long to merge. For some reason this PR fell off my radar. |
Contributor
Author
|
no worries, thanks @mvriel :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussions in #9, this PR provides improvements to the former:
T_CURLY_OPENandT_DOLLAR_OPEN_CURLY_BRACES(these were indeed silently failing previously) and adds test@coversannotation fortestTraitUseIsNotDetectedAsNamespaceUse