bump phpstan to master #201
Conversation
|
I had to double down on a hack in the code documentation: https://github.com/phpDocumentor/ReflectionDocBlock/pull/201/files#diff-24bbef7e3801a14d93d080b7875d5ef6R179 This is due to a bug in PHPStan's extension for Webmozart/Assert. We'll be able to remove it when phpstan/phpstan-webmozart-assert#18 is fixed. |
|
@jaapio Weird, CI seems broken on pull requests. It only ran Scrutinizer... |
|
Build on pr is fixed. Please rebase this PR, let me know when it is ready to merge 👍 |
|
This is ready for review |
There was a problem hiding this comment.
Thanks a lot for these changes.
Another step forward to a better typed lib!
I delay the actual merge because I want to add some additional tooling to the CI to ensure we are not breaking backwards compatiblity. That needs some time. I don't expect this pr to change anything. But since I'm not familiar with the specific tool I don't want to have any commits in here right now that possibly have influence on the tool.
|
No worries, I know this is highly sensitive. I don't want to break anything that will annoy a lot of people :D |
|
No Bc breaks on api level, So I expect this to be safe :-) |
2 participants
Also fixed ignored errors (FYI, PHPStan ignore rule are regexes. The previous error had "|string>" at the end. The effect was that every error ending by "|string>" was being ignored. Newer versions of PHPStan now warn about that)