[WIP] PHP 8.5 release page #1454
Conversation
|
🚀 Regression report for commit 55be0cb is at https://web-php-regression-report-pr-1454.preview.thephp.foundation |
|
🚀 Preview for commit 55be0cb can be found at https://web-php-pr-1454.preview.thephp.foundation |
releases/8.5/release.inc
Outdated
| $versions = ['PHP 8.1', 'PHP 8.2', 'PHP 8.3', 'PHP 8.4', 'PHP 8.5']; | ||
| var_dump($versions[array_key_first($versions)]); | ||
| // string(7) "PHP 8.1" |
There was a problem hiding this comment.
I find this example too simple to be useful, especially because $versions[0] works for a list. Perhaps we can find something with an associative array?
Co-authored-by: Tim Düsterhus <[email protected]>
| $upcomingRelease = null; | ||
| foreach ($php as $key => $version) { | ||
| if ($version['state'] === 'upcoming') { | ||
| $upcomingRelease = $version; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not a good example, because this could just be array_find().
| $upcomingRelease = array_first( | ||
| array_filter( | ||
| $php, | ||
| static fn($version) => $version['state'] === 'upcoming' | ||
| ) | ||
| ); |
| <div class="php8-compare__main"> | ||
| <div class="php8-compare__block example-contents"> | ||
| <div class="php8-compare__label">PHP < 8.5</div> | ||
| <div class="php8-code phpcode"> | ||
| <?php highlight_php_trimmed( | ||
| <<<'PHP' | ||
| $sh = curl_share_init(); | ||
| curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS); | ||
| curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT); | ||
| $ch1 = curl_init('https://php.net/'); | ||
| curl_setopt($ch1, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch1); | ||
| $ch2 = curl_init('https://thephp.foundation/'); | ||
| curl_setopt($ch2, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch2); | ||
| curl_share_close($sh); | ||
| curl_close($ch1); | ||
| curl_close($ch2); | ||
| PHP | ||
|
|
||
| ); ?> | ||
| </div> | ||
| </div> | ||
| <div class="php8-compare__arrow"></div> | ||
| <div class="php8-compare__block example-contents" style="display: table;"> | ||
| <div class="php8-compare__label php8-compare__label_new">PHP 8.5</div> | ||
| <div class="php8-code phpcode" style="display: table-cell;"> | ||
| <?php highlight_php_trimmed( | ||
| <<<'PHP' | ||
| $sh = curl_share_init_persistent([ | ||
| CURL_LOCK_DATA_DNS, | ||
| CURL_LOCK_DATA_CONNECT | ||
| ]); | ||
| $ch1 = curl_init('https://php.net/'); | ||
| curl_setopt($ch1, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch1); | ||
| $ch2 = curl_init('https://thephp.foundation/'); | ||
| curl_setopt($ch2, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch2); | ||
| curl_close($ch1); | ||
| curl_close($ch2); | ||
| PHP | ||
| ); ?> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
This comparison is not really meaningful to understand what has changed. At least some explanation is necessary. curl_close() should be removed in all cases, since it is useless with 8.0 and deprecated with 8.5.
| #[DataProvider('subtractionProvider')] | ||
| public function testSubtraction( | ||
| int $minuend, | ||
| int $subtrahend, | ||
| int $result | ||
| ): void | ||
| { | ||
| $this->assertSame( | ||
| $result, | ||
| Calculator::subtract($minuend, $subtrahend) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This should be kept in sync with the 8.5 version. Unfortunately the 8.5 version can't yet use PHPUnit, since sebastianbergmann/phpunit#6136 is not implemented yet. So both should use some “generic test framework”.
Co-authored-by: Tim Düsterhus <[email protected]>
releases/8.5/release.inc
Outdated
| |> (fn (string $string) => str_replace(' ', '-', $string)) | ||
| |> (fn (string $string) => str_replace(['.', '/', '…'], '', $string)) |
There was a problem hiding this comment.
| |> (fn (string $string) => str_replace(' ', '-', $string)) | |
| |> (fn (string $string) => str_replace(['.', '/', '…'], '', $string)) | |
| |> (fn($string) => str_replace(' ', '-', $string)) | |
| |> (fn($string) => str_replace(['.', '/', '…'], '', $string)) |
No space after fn for PER-CS. Removed the type, because it seems unlikely for folks to add an explict type in pipes, which will also shorten the line.
/cc @Crell
Co-authored-by: Tim Düsterhus <[email protected]>
Preview: https://web-php-pr-1454.preview.thephp.foundation/releases/8.5/en.php