Skip to content

Fix memory leak in fiber constructor #9098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

Fix memory leak in fiber constructor #9098

merged 1 commit into from
Jul 22, 2022

Conversation

kooldev
Copy link
Contributor

@kooldev kooldev commented Jul 22, 2022 •
edited
Loading

Fixes memory leak due to multiple calls to fiber constructor as reported in #8367.

@trowski Multiple calls to fiber constructor are prevented by throwing an error. The error message is identical to the one being used by Phar and PharFileInfo in this situation.

@devnexen devnexen requested a review from trowski July 22, 2022 15:03
trowski
trowski approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trowski trowski changed the base branch from PHP-8.1 to master July 22, 2022 15:46
@trowski trowski merged commit 0adbf9c into php:master Jul 22, 2022
@trowski trowski mentioned this pull request Jul 22, 2022
Closed
@kooldev kooldev deleted the fix-bug-8367 branch July 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski approved these changes

Assignees
No one assigned
Labels
Category: Fibers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kooldev @trowski @devnexen