Don't test hidden files that happen to end in .phpt #7783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 15, 2021
|
I guess we could ignore any file that starts with a dot. It would be a more general solution. |
I'm okay with that, but not necessarily with special casing for whatever editor/IDE. |
cscott
force-pushed
the
dont-test-emacs-autosave
branch
2 times, most recently
from
48e3ce4 to
bdb98a3
Compare
cscott
changed the title
Ok, tweaked to ignore files starting with a dot. That makes sense. Various filesystems use these for metadata of various forms, too. |
cmb69
reviewed
Dec 16, 2021
cscott
force-pushed
the
dont-test-emacs-autosave
branch
2 times, most recently
from
a840e57 to
306f2e3
Compare
|
If there are no objections, I'll merge that by the end of the week. |
cmb69
approved these changes
Dec 20, 2021
This is a tiny improvement to run-tests.php which helps keep it from tripping over hidden files, including autosave files from various editors, metadata on certain platforms, etc.
cscott
force-pushed
the
dont-test-emacs-autosave
branch
from
306f2e3 to
9026290
Compare
|
Rebased onto current master to (hopefully) fix CI issues. No other changes. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny improvement to run-tests.php which helps keep it from tripping over hidden files, including emacs autosave files, metadata files on some platforms, etc.