Skip to content

remove duplicated deps and add required deps #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

7snovic
Copy link
Contributor

@7snovic 7snovic commented Dec 6, 2021

there are some duplicated deps and libjpeg-dev and libjpng-dev raised an errors on my machine when I was using this script to compile the src code

@7snovic 7snovic changed the title remove duplicates and add required libs remove duplicated deps and add required deps Dec 6, 2021
@cmb69
Copy link
Member

cmb69 commented Dec 6, 2021

Removing the duplicates makes sense, but why should we install the additional libs? Are there any tests skipped on Azure Pipelines without? It doesn't look like that.

@7snovic
Copy link
Contributor Author

7snovic commented Dec 7, 2021

@cmb69 not sure if they cause a skipped tests on Azure, I just got some errors on the ./configure level when I was trying to build the bin using the Azure build scripts

@cmb69
Copy link
Member

cmb69 commented Dec 7, 2021

I haven't thoroughly checked, but I assume these packages are preinstalled on the Azure VMs; that does not imply that they are preinstalled everywhere else, but these scripts are neither documentation nor examples, but rather setup scripts for CI.

@7snovic
Copy link
Contributor Author

7snovic commented Dec 7, 2021

@cmb69 yes I know, these deps can be omitted after all.

@7snovic
Copy link
Contributor Author

7snovic commented Dec 8, 2021

Well, the scenario was to use the Azure build script to build PHP with the same configs to be able to reproduce the error which was happening in Azure but was not producible on my local machine. so I used this script and I get these errors.

@cmb69
Copy link
Member

cmb69 commented Dec 8, 2021

Well, the scenario was to use the Azure build script to build PHP with the same configs to be able to reproduce the error which was happening in Azure but was not producible on my local machine.

I see your point, but there is no guarantee that this would allow you to reproduce these issue.

@krakjoe, since you originally set up Azure Pipelines CI, what do you think about this PR (especially installing the apparently not strictly needed libraries).

@7snovic
Copy link
Contributor Author

7snovic commented Dec 8, 2021

I see your point, but there is no guarantee that this would allow you to reproduce these issues.

Actually, this fixed my missed building configs and I was able to reproduce the error that was not reproducible with my previous setup

@cmb69 cmb69 merged commit e72b2f3 into php:master Dec 23, 2021
@cmb69
Copy link
Member

cmb69 commented Dec 23, 2021

Okay, then let's go with this. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants