Add all the missing parameter types to stubs #5955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Aug 7, 2020
ext/pdo/pdo_stmt.c
Outdated
| @@ -40,6 +40,12 @@ | |||
| RETURN_FALSE; \ | |||
| } \ | |||
|
|
|||
| #define PHP_STMT_GET_OBJ_INT \ | |||
There was a problem hiding this comment.
We should be throwing an exception in this case, right? (in PHP_STMT_GET_OBJ as well)
kocsismate
force-pushed
the
stub-types3
branch
2 times, most recently
from
89617da to
4a4b29d
Compare
kocsismate
commented
Aug 7, 2020
kocsismate
force-pushed
the
stub-types3
branch
4 times, most recently
from
3822d0f to
5dfc2fe
Compare
Girgias
reviewed
Aug 9, 2020
kocsismate
force-pushed
the
stub-types3
branch
from
5dfc2fe to
2d593ca
Compare
nikic
reviewed
Aug 12, 2020
kocsismate
force-pushed
the
stub-types3
branch
3 times, most recently
from
f91f000 to
bd0d84d
Compare
kocsismate
force-pushed
the
stub-types3
branch
from
bd0d84d to
e143d96
Compare
kocsismate
force-pushed
the
stub-types3
branch
from
1614acd to
31fbbc0
Compare
|
Looks like there's still test failures. |
kocsismate
commented
Aug 12, 2020
nikic
reviewed
Aug 13, 2020
kocsismate
force-pushed
the
stub-types3
branch
from
db91143 to
9bccd06
Compare
nikic
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP now provides complete type information (at least in an informal way) for each and every function and method.