Drop '#if 0' in mysqlnd_debug() from the MySQLnd extension #5587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
May 17, 2020
Girgias
force-pushed
the
mysqlnd-if0-to-ifdebug
branch
from
97e0b73 to
ba3d68c
Compare
Girgias
changed the title
Girgias
force-pushed
the
mysqlnd-if0-to-ifdebug
branch
from
ba3d68c to
7a71dad
Compare
nikic
reviewed
Aug 6, 2020
| die("skip: debug functionality not enabled"); | ||
|
|
||
| if (!$IS_MYSQLND) | ||
| if (!$IS_MYSQLND) |
|
|
||
| mysqli_close($link); | ||
| # | ||
| #mysqli_close($link); |
|
|
||
| Warning: mysqli_debug(): Unrecognized format 'z' in %s on line %d | ||
|
|
||
| donelibmysql/DBUG package prints some debug info here. |
Girgias
force-pushed
the
mysqlnd-if0-to-ifdebug
branch
2 times, most recently
from
9d52a23 to
b806da0
Compare
Girgias
force-pushed
the
mysqlnd-if0-to-ifdebug
branch
from
b806da0 to
4581ef5
Compare
nikic
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty confused as to why this part was being excluded as this seems to be valuable debug information.
We may want to drop the
#ifchecks completely.