Skip to content

Drop '#if 0' in mysqlnd_debug() from the MySQLnd extension #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented May 17, 2020

I'm pretty confused as to why this part was being excluded as this seems to be valuable debug information.

We may want to drop the #if checks completely.

@Girgias Girgias force-pushed the mysqlnd-if0-to-ifdebug branch from 97e0b73 to ba3d68c Compare May 17, 2020 21:59
@Girgias Girgias changed the title Change #if 0 to #if PHP_DEBUG in MySQLnd extension Drop '#if 0' in mysqlnd_debug() from the MySQLnd extension May 17, 2020
@Girgias Girgias force-pushed the mysqlnd-if0-to-ifdebug branch from ba3d68c to 7a71dad Compare May 17, 2020 23:24
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally fine. The Travis failure is relevant.

die("skip: debug functionality not enabled");

if (!$IS_MYSQLND)
if (!$IS_MYSQLND)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these whitespace changes?


mysqli_close($link);
#
#mysqli_close($link);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented?


Warning: mysqli_debug(): Unrecognized format 'z' in %s on line %d

donelibmysql/DBUG package prints some debug info here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably stay done%s.

@Girgias Girgias force-pushed the mysqlnd-if0-to-ifdebug branch 2 times, most recently from 9d52a23 to b806da0 Compare August 6, 2020 14:12
@Girgias Girgias force-pushed the mysqlnd-if0-to-ifdebug branch from b806da0 to 4581ef5 Compare August 6, 2020 15:27
@php-pulls php-pulls closed this in c740019 Aug 7, 2020
@Girgias Girgias deleted the mysqlnd-if0-to-ifdebug branch August 7, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants