-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Drop '#if 0' in mysqlnd_debug() from the MySQLnd extension #5587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97e0b73
to
ba3d68c
Compare
ba3d68c
to
7a71dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally fine. The Travis failure is relevant.
die("skip: debug functionality not enabled"); | ||
|
||
if (!$IS_MYSQLND) | ||
if (!$IS_MYSQLND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these whitespace changes?
|
||
mysqli_close($link); | ||
# | ||
#mysqli_close($link); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented?
|
||
Warning: mysqli_debug(): Unrecognized format 'z' in %s on line %d | ||
|
||
donelibmysql/DBUG package prints some debug info here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably stay done%s
.
9d52a23
to
b806da0
Compare
b806da0
to
4581ef5
Compare
I'm pretty confused as to why this part was being excluded as this seems to be valuable debug information.
We may want to drop the
#if
checks completely.