-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix FR #71885 (Allow escaping question mark placeholders) #4217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --TEST-- | ||
| PDO Common: FR #71885 (Allow escaping question mark placeholders) | ||
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded('pdo')) die('skip'); | ||
| $dir = getenv('REDIR_TEST_DIR'); | ||
| if (false == $dir) die('skip no driver'); | ||
| if (!strncasecmp(getenv('PDOTEST_DSN'), 'pgsql', strlen('pgsql'))) die('skip not relevant for pgsql driver'); | ||
| if (!strncasecmp(getenv('PDOTEST_DSN'), 'odbc', strlen('odbc'))) die('skip inconsistent error message with odbc'); | ||
| require_once $dir . 'pdo_test.inc'; | ||
| PDOTest::skip(); | ||
| ?> | ||
| --FILE-- | ||
| <?php | ||
| if (getenv('REDIR_TEST_DIR') === false) putenv('REDIR_TEST_DIR='.dirname(__FILE__) . '/../../pdo/tests/'); | ||
| require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc'; | ||
| $db = PDOTest::factory(); | ||
| $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); | ||
|
|
||
| $db->exec("CREATE TABLE test (a int)"); | ||
|
|
||
| $sql = "SELECT * FROM test WHERE a ?? 1"; | ||
|
|
||
| try { | ||
| $db->exec($sql); | ||
| } catch (PDOException $e) { | ||
| var_dump(strpos($e->getMessage(), "?") !== false); | ||
| } | ||
|
|
||
| try { | ||
| $stmt = $db->prepare($sql); | ||
| $stmt->execute(); | ||
| } catch (PDOException $e) { | ||
| var_dump(strpos($e->getMessage(), "?") !== false); | ||
| } | ||
|
|
||
| if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'mysql') { | ||
| $db->setAttribute(PDO::ATTR_EMULATE_PREPARES, 1); | ||
| } | ||
|
|
||
| try { | ||
| $stmt = $db->prepare($sql); | ||
| $stmt->execute(); | ||
| } catch (PDOException $e) { | ||
| var_dump(strpos($e->getMessage(), "?") !== false); | ||
| } | ||
|
|
||
| ?> | ||
| ===DONE=== | ||
| --EXPECT-- | ||
| bool(true) | ||
| bool(true) | ||
| bool(true) | ||
| ===DONE=== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --TEST-- | ||
| Request #71855 (PDO placeholder escaping) | ||
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded'); | ||
| require_once dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc'; | ||
| require_once dirname(__FILE__) . '/config.inc'; | ||
| PDOTest::skip(); | ||
| ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc'; | ||
| require_once dirname(__FILE__) . '/config.inc'; | ||
| $db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt'); | ||
| $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); | ||
| $db->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_NUM); | ||
|
|
||
| foreach ([false, true] as $emulate) { | ||
| $db->setAttribute(PDO::ATTR_EMULATE_PREPARES, $emulate); | ||
|
|
||
| try { | ||
| $stmt = $db->prepare('select ?- lseg \'((-1,0),(1,0))\''); | ||
| $stmt->execute(); | ||
| } catch (PDOException $e) { | ||
| var_dump('ERR'); | ||
| } | ||
|
|
||
| $stmt = $db->prepare('select ??- lseg \'((-1,0),(1,0))\''); | ||
| $stmt->execute(); | ||
|
|
||
| var_dump($stmt->fetch()); | ||
| } | ||
|
|
||
| ?> | ||
| ==OK== | ||
| --EXPECT-- | ||
| string(3) "ERR" | ||
| array(1) { | ||
| [0]=> | ||
| bool(true) | ||
| } | ||
| array(1) { | ||
| [0]=> | ||
| bool(true) | ||
| } | ||
| ==OK== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| --TEST-- | ||
| Request #71855 (PDO placeholder escaping, part 2) | ||
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded'); | ||
| require_once dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc'; | ||
| require_once dirname(__FILE__) . '/config.inc'; | ||
| PDOTest::skip(); | ||
|
|
||
| $db = PDOTest::factory(); | ||
| if (version_compare($db->getAttribute(PDO::ATTR_SERVER_VERSION), '9.4.0') < 0) { | ||
| die("skip Requires 9.4+"); | ||
| } | ||
|
|
||
| ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc'; | ||
| require_once dirname(__FILE__) . '/config.inc'; | ||
| $db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt'); | ||
| $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); | ||
| $db->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_NUM); | ||
|
|
||
| $jsonb = $db->quote(json_encode(['a' => 1])); | ||
|
|
||
| foreach ([false, true] as $emulate) { | ||
| $db->setAttribute(PDO::ATTR_EMULATE_PREPARES, $emulate); | ||
|
|
||
| $stmt = $db->prepare("SELECT {$jsonb}::jsonb ?? ?"); | ||
| $stmt->execute(['b']); | ||
| var_dump($stmt->fetch()); | ||
|
|
||
| $stmt = $db->prepare("SELECT {$jsonb}::jsonb ???"); | ||
| $stmt->execute(['a']); | ||
| var_dump($stmt->fetch()); | ||
| } | ||
|
|
||
| ?> | ||
| ==OK== | ||
| --EXPECT-- | ||
| array(1) { | ||
| [0]=> | ||
| bool(false) | ||
| } | ||
| array(1) { | ||
| [0]=> | ||
| bool(true) | ||
| } | ||
| array(1) { | ||
| [0]=> | ||
| bool(false) | ||
| } | ||
| array(1) { | ||
| [0]=> | ||
| bool(true) | ||
| } | ||
| ==OK== |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without, it doesn't work properly. When running the new pdo_pgsql tests, there is a code path that sends a non-quoted "?". I'll try to figure out how and when this afternoon.