Skip to content

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Sep 4, 2025

The error messages in fpm_conf_process_all_pools() all deserve some clean-up, but this one was particularly bad, since it didn't explain the issue at all.

@TimWolla TimWolla requested a review from a team September 4, 2025 08:14
@TimWolla TimWolla requested a review from bukka as a code owner September 4, 2025 08:14
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a message change - RM and technical review performed, LGTM

@TimWolla
Copy link
Member Author

TimWolla commented Sep 4, 2025

@bukka Message adjusted and test added.

@TimWolla TimWolla requested a review from bukka September 4, 2025 12:32
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That env solution makes sense.

@TimWolla TimWolla merged commit 066553c into php:master Sep 4, 2025
9 checks passed
@TimWolla TimWolla deleted the fpm-root-error branch September 5, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants