Skip to content

Conversation

DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer
Copy link
Member Author

Cross link #17599

@DanielEScherzer DanielEScherzer marked this pull request as ready for review April 30, 2025 03:43
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try to understand all of the changes, but the changes to the arginfo LGTM. Leaving the final approval to Mate.

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit

Co-authored-by: Máté Kocsis <[email protected]>
@DanielEScherzer DanielEScherzer merged commit 940ee1a into php:master May 4, 2025
8 of 9 checks passed
@DanielEScherzer DanielEScherzer deleted the stub-NoDiscard branch May 4, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants