Skip to content

[skip ci] Document HASH_ constants #16806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

[skip ci] Document HASH_ constants #16806

merged 1 commit into from
Nov 18, 2024

Conversation

iluuu1994
Copy link
Member

Not all of these are straight-forward to understand.

@iluuu1994
[skip ci] Document HASH_ constants
ff789a4 
Not all of these are straight-forward to understand.
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner November 14, 2024 21:52
TimWolla
TimWolla approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thank you.

Girgias
Girgias approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the comments are helpful as I find the internals Hash API to be confused.

@iluuu1994 iluuu1994 merged commit 4b517a9 into php:master Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@dstogov dstogov dstogov approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iluuu1994 @TimWolla @dstogov @Girgias