Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 30, 2024

For debugging and development purposes it is occasionally useful to one run one of the nightly jobs manually. We support that by adding a choice input where the desired job can be selected (* means run all jobs).

Note that we generate the matrix even when it's not required, and that we do not support constraining the matrix for now.

For debugging and development purposes it is occasionally useful to
one run one of the nightly jobs manually.  We support that by adding a
choice input where the desired job can be selected (`*` means run all
jobs).

Note that we generate the matrix even when it's not required, and that
we do not support constraining the matrix for now.
@cmb69 cmb69 requested a review from TimWolla as a code owner September 30, 2024 21:13
@cmb69 cmb69 requested review from iluuu1994 and removed request for TimWolla September 30, 2024 21:13
@cmb69 cmb69 changed the base branch from PHP-8.4 to master September 30, 2024 21:31
@cmb69
Copy link
Member Author

cmb69 commented Sep 30, 2024

Changed target branch according to #16118 (comment).

@iluuu1994
Copy link
Member

@cmb69 Sadly, I think my comment doesn't apply here, since this is not the cron trigger, but the workflow trigger. With this one, the input fields are loaded for the branch that is picked...

@cmb69
Copy link
Member Author

cmb69 commented Sep 30, 2024

@iluuu1994, isn't that what we want: to run the manual workflow from the master branch, to be able to check how the schedule triggered workflow would behave?

@iluuu1994
Copy link
Member

@cmb69 We would also want to be able to trigger the older branches, if necessary. But if this is only merged to master, the dropdown won't be available in these branches, including PRs created from them.

token: ${{ secrets.ACTION_MONITORING_SLACK }}
COVERAGE_DEBUG_NTS:
if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch'
if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS')
Copy link
Member

@iluuu1994 iluuu1994 Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. It wouldn't execute on workflow_dispatch in forks anymore.

Suggested change
if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS')
if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS'))

token: ${{ secrets.ACTION_MONITORING_SLACK }}
PECL:
if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch'
if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL')
Copy link
Member

@iluuu1994 iluuu1994 Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to:

Suggested change
if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL')
if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'PECL'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants