Skip to content

ext/gmp: gmp_invert addressing todo. #13654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Mar 9, 2024

No description provided.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the following test case (previously this threw an exception, now it returns false):

<?php
$zero = new GMP(0);
var_dump(gmp_invert(5, $zero));

And since CI didn't catch this, perhaps this should be a regression test?

@devnexen
Copy link
Member Author

devnexen commented Mar 9, 2024

good idea will add this one.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems correct to me.

@devnexen devnexen merged commit bb1ef4f into php:master Mar 9, 2024
@Girgias Girgias removed their request for review March 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants