Skip to content

Change return type of hash_update() to true #13652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ PHP NEWS
. bind_textdomain_codeset now throws an exception on empty domain.
(David Carlier)

- Hash:
. Changed return type of hash_update() to true. (nielsdos)

- IMAP:
. Moved to PECL. (Derick Rethans)

Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,10 @@ PHP 8.4 UPGRADE NOTES
- Gettext:
. bind_textdomain_codeset now throws an exception if the domain's argument is empty.

- Hash:
. Changed the return type of hash_update() to true. It was already the case that only
true could be returned, but the stub was not updated yet.

- Intl:
. IntlDateFormatter::__construct() throws a ValueError if the locale is invalid.
. NumberFormatter::__construct() throws a ValueError if the locale is invalid.
Expand Down
2 changes: 1 addition & 1 deletion ext/hash/hash.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function hash_hmac_file(string $algo, string $filename, #[\SensitiveParameter] s
*/
function hash_init(string $algo, int $flags = 0, #[\SensitiveParameter] string $key = "", array $options = []): HashContext {}

function hash_update(HashContext $context, string $data): bool {}
function hash_update(HashContext $context, string $data): true {}

/** @param resource $stream */
function hash_update_stream(HashContext $context, $stream, int $length = -1): int {}
Expand Down
4 changes: 2 additions & 2 deletions ext/hash/hash_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.