use php_mt_rand_range for 8.4 #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Oct 11, 2024
using mcrypt is a security problem in all cases, as the library is dead for >10 years ;) |
smoser
added a commit
to smoser/wolfi-os
that referenced
this pull request
Nov 20, 2024
Grab php/pecl-encryption-mcrypt#19 which just uses php_mt_rand_range rather than now-removed php_rand.
smoser
added a commit
to smoser/wolfi-os
that referenced
this pull request
Nov 21, 2024
Grab php/pecl-encryption-mcrypt#19 which just uses php_mt_rand_range rather than now-removed php_rand.
|
Can we see this merged @derickr ? |
smoser
added a commit
to wolfi-dev/os
that referenced
this pull request
Nov 21, 2024
First, just add the modules, copying from 8.3 versions.
$ for p in php-8.3-*.yaml; do
sed -e 's,epoch: .*,epoch: 0,' \
-e 's,name: php-8.3-,name: php-8.4-,' \
"$p" > php-8.4${p#php-8.3};
done
Then fix some to build with 8.4, cherry picking from upstream.
* php-8.4-pecl-mcrypt - cherry-pick a PR to build for 8.4
Grab php/pecl-encryption-mcrypt#19
which just uses php_mt_rand_range rather than now-removed php_rand.
* php-8.4-imagick - cherry pick pr to build for 8.4
Grab Imagick/imagick#690
to replace php_strlower with zend_str_tolower
* php-8.4-xdebug - cherry pick several upstream changes
NOTE: I have very low confidence in this, other than it builds.
xdebug is active and likely to release a 3.4.0 release soon
that has php 8.4 support properly.
By adding php-8.4-xdebug with updates enabled, we will get
a PR automatically made and hopefully landed just by dropping
the cherry-picks here.
* Drop php-8.4-swoole - not supported upstream yet.
Several changes would be needed to make the 5.1.5
version of swoole build with php 8.4.
Upstream explicitly removed support from
the 5.1 branch swoole/swoole-src#5525
There is likely 6.0.0 release coming soon (beta released 2024-10-17).
We will have to manually re-add at that point in time.
* php-8.4-memcached and php-8.4-redis are separated out to another PR
as they are dependent on php-8.4-igbinary output.
Closed
|
The mcrypt extension is deprecrated, please please please upgrade your code base to something newer. A new release will be here soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_mt_rand_range exists since 5.6
php_rand dropped in 8.4