Remove HAVE_SIGNAL_H symbol #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signal.h header is part of the C89 standard and is present on all today's systems already. The HAVE_SIGNAL_H symbol is defined by PHP's build system and relying on it is neither a good practice neither needed anymore since the signal.h check would always define it. http://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
|
Yeah, I guess that could be done ... while this is only kept for compatibility anyways and users should migrate to mysqli or pdo. |
|
Great, thanks for the reply. Next step would be probably merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signal.h header is part of the C89 standard and is present on all today's systems already. The HAVE_SIGNAL_H symbol is defined by PHP's build system and relying on it is neither a good practice neither needed anymore since the signal.h check would always define it.
http://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
Related to removal via php/php-src#4298