Skip to content

better doc for setlocale #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

better doc for setlocale #4770

merged 1 commit into from
Jul 11, 2025

Conversation

remicollet
Copy link
Member

Following PR #4765

@remicollet remicollet mentioned this pull request Jul 11, 2025
Merged
@remicollet
Copy link
Member Author

To summarize

  • empty string have same behavior than glibc
  • null works as empty string because of old null to string conversion (since always)
  • "0" is a hack to use glibc null behavior

Yes, this is ugly, but probably not worth to be fixed (hard to diagnose BC break)

nielsdos
nielsdos approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up

@remicollet remicollet merged commit 09324fb into php:master Jul 11, 2025
2 checks passed
@remicollet
Copy link
Member Author

Thanks for reviews, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@PhilDaiguille PhilDaiguille PhilDaiguille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remicollet @nielsdos @PhilDaiguille