Skip to content

Document boolean support for allowed_classes in unserialize #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document boolean support for allowed_classes in unserialize #4768

wants to merge 1 commit into from

Conversation

ImperialCrise
Copy link

  • In appendices/migration84/incompatible.xml, update the description of the allowed_classes option to indicate it may be an array of class names or at boolean.
  • In reference/var/functions/unserialize.xml, clarify that unserialize() throws TypeError and ValueError if options.allowed_classes is not an array or boolean.

@ImperialCrise ImperialCrise mentioned this pull request Jul 9, 2025
Closed
@ImperialCrise
Copy link
Author

This stems from the issue that arose because the documentation wasn’t clear:
php/php-src#19082

@ImperialCrise
Document boolean support for allowed_classes in unserialize
f7713b2 
- In appendices/migration84/incompatible.xml, update the description of the
  allowed_classes option to indicate it may be an array of class names or at
  boolean.
- In reference/var/functions/unserialize.xml, clarify that unserialize() throws
  TypeError and ValueError if options.allowed_classes is not an array or boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilDaiguille PhilDaiguille PhilDaiguille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImperialCrise @PhilDaiguille