Fix: Add explicit $escape parameter in fputcsv for PHP 8.4 compatibility #4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation warning in PHP 8.4 This commit resolves a deprecation warning in PHP 8.4 regarding the $escape parameter of the fputcsv function. The warning indicates that the default value for $escape will change in future PHP versions, requiring it to be explicitly provided.
Girgias
requested changes
Dec 9, 2024
Co-authored-by: Gina Peter Banyard <[email protected]>
Girgias
approved these changes
Dec 10, 2024
|
Thank you! |
siwa32
added a commit
to siwa32/doc-ja
that referenced
this pull request
Jan 13, 2025
KentarouTakeda
added a commit
to php/doc-ja
that referenced
this pull request
Jan 19, 2025
* PHP 8.4: CSV related changes and deprecations の取り込み php/doc-en#4093 以下も合わせて取り込む reference/spl/splfileobject/setcsvcontrol.xml - [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations - php/doc-en#4128 - Update setcsvcontrol.xml Fix typo - php/doc-en#4379 reference/spl/splfileobject/fgetcsv.xml - Update fgetcsv.xml Remove the duplicate sentence - php/doc-en#4111 * Fix GH-4175: do not say the parameters are optional の取り込み php/doc-en#4177 * Document str_getcsv() and fgetcsv() change in 8.3.0 (closes #4197) の取り込み php/doc-en#4198 * Fix: Add explicit $escape parameter in fputcsv for PHP 8.4 compatibility の取り込み php/doc-en#4283 * 改行位置を原文と合わせる対応 --------- Co-authored-by: 武田 憲太郎 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a deprecation warning in PHP 8.4 regarding the $escape parameter of the fputcsv function. The warning indicates that the default value for $escape will change in future PHP versions, requiring it to be explicitly provided.
Updated the fputcsv calls to include the $escape parameter explicitly with a backslash ('\') as the value.
Ensures compatibility with PHP 8.4.
Prevents potential future errors caused by the deprecation of the default $escape parameter value.
This update makes the script more robust and ready for future PHP versions.