Skip to content

Update simplexml_import_dom for PHP 8.4 #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update simplexml_import_dom for PHP 8.4 #3906

merged 2 commits into from
Oct 23, 2024

Conversation

nielsdos
Copy link
Member

No description provided.

@nielsdos nielsdos mentioned this pull request Oct 23, 2024
Open
Girgias
Girgias approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup nit, but LGTM.

Thank you!

@nielsdos nielsdos merged commit 6251438 into php:master Oct 23, 2024
2 checks passed
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 7, 2024
Open
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias